On Sun, Oct 04, 2015 at 07:33:34PM +0100, Greg KH wrote: > On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio L?pez wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct bin_attribute." > > > > but this isn't the case, as is_visible is only called on struct attribute > > only. This patch introduces a new is_bin_visible() function to implement > > the same functionality for binary attributes, and updates documentation > > accordingly. > > > > Note that to keep functionality and code similar to that of normal > > attributes, the mode is now checked as well to ensure it contains only > > read/write permissions or SYSFS_PREALLOC. > > > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > Signed-off-by: Emilio L?pez <emilio.lopez@xxxxxxxxxxxxxxx> > > As this should probably go through the "platform drivers" maintainer, > I'll just give you this: > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > So it can go through their tree and not require me to just take this > one. Thanks, applied to the chrome-platform tree now. -Olof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
