On Tuesday 06 October 2015 17:51:30 Florian Fainelli wrote: > On 06/10/15 12:59, Arnd Bergmann wrote: > > The newly added pwm-brcmstb driver fails to build if CONFIG_PM_SLEEP > > is enabled: > > > > drivers/pwm/pwm-brcmstb.c: In function 'brcmstb_pwm_suspend': > > drivers/pwm/pwm-brcmstb.c:309:42: error: 'dev' undeclared (first use in this function) > > struct brcmstb_pwm *p = dev_get_drvdata(dev); > > > > This changes the name of the function argument to match its user. > > Thanks, maybe, to avoid similar issues in the future, we should start > removing the ifdef CONFIG_PM_SLEEP and instead annotate such functions > with __maybe_unused. I wonder if we could magically make that happen > with a coccinelle script that looks for SIMPLE_DEV_PM_OPS to know which > functions to annotate... humm. I think the best solution would be to replace SIMPLE_DEV_PM_OPS with a macro that creates an unused reference to the functions. That way, we could remove all the #ifdef CONFIG_PM_SLEEP from the kernel, but we'd still have to use coccinelle to replace all the current instances with the new macro. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
