Hi Stephen, No there is no reason. I will fix it. Thanks for review. Best regards Gabriel On 6 October 2015 at 20:06, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 10/05, Gabriel Fernandez wrote: >> @@ -452,7 +651,7 @@ static const struct clk_ops st_pll1200c32_ops = { >> static struct clk * __init clkgen_pll_register(const char *parent_name, >> struct clkgen_pll_data *pll_data, >> void __iomem *reg, >> - const char *clk_name) >> + const char *clk_name, spinlock_t *lock) > > Is there a reason we pass lock here but never use it in this > function? > >> { >> struct clkgen_pll *pll; >> struct clk *clk; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html