Philipp Zabel <philipp.zabel@xxxxxxxxx> writes: > On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: >> + lcd-controller@40500000 { >> + compatible = "marvell,pxa2xx-lcdc"; >> + reg = <0x44000000 0x10000>; >> + interrupts = <17>; >> + clocks = <&clks CLK_LCD>; >> + interrupts = <23>; > > The interrupt line is duplicated in the example. Indeed, I'll fix that. > >> + status = "okay"; >> + >> + port { >> + lcdc_out: endpoint { >> + remote-endpoint = <&panel_in>; >> + bus-width = <16>; >> + }; >> + }; >> + }; >> + >> +PXA LCDC Display >> +---------------- >> +Required properties (as per of_videomode_helper): >> + - lcd-type: either "mono-stn", "mono-dstn", "color-stn", "color-dstn", >> + "color-tft", "smart-panel" > > Would it make sense to make this property optional and have the > default be "color-tft"? That is probably the most common one by far. Yes, sure, let's do it that way for v3. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html