On October 05, 2015 16:56, Mark Brown wrote:
> On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote:
>
> > This patch adds support for DT bindings in the codec driver.
> > As part of this support, the mclk data can now be provided and
> > used to control the mclk during codec operation.
>
> Please split out the new MCLK configuration into a separate patch which
> describes what that configuration is, it's much easier to review that
> way. Otherwise there's a couple of minor issues here but nothing too
> critical.
Ok, no problem. Will do.
>
> > case SND_SOC_BIAS_STANDBY:
> > if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_OFF) {
> > + /* MCLK */
> > + clk_prepare_enable(da7213->mclk);
> > +
>
> This doesn't check the return value.
Yep, will update.
>
> > .driver = {
> > .name = "da7213",
> > + .of_match_table = da7213_of_match,
>
> Please use of_match_ptr() here.
Ok, didn't know about that. Will update.
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
