On Mon, Oct 5, 2015 at 1:03 PM, Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx> wrote: > + /* Register IRQ */ > + irq = platform_get_irq_byname(pdev, "FG"); > + if (irq < 0) { > + dev_err(dev, "Failed to get IRQ FG: %d\n", irq); You need to do "ret = irq" here. Otherwise you will return success in irq_fail. > + goto irq_fail; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html