Hello Doug, On 09/29/2015 07:28 PM, Doug Anderson wrote: [snip] > > >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684 ++++++++++++++++++++++++++ >> arch/arm/boot/dts/exynos5250-snow-rev5.dts | 47 ++ >> arch/arm/boot/dts/exynos5250-snow.dts | 666 +------------------------ >> 4 files changed, 733 insertions(+), 665 deletions(-) > > Thanks! Note: > > $ pwclient git-am 7285451 > Applying patch #7285451 using 'git am' > Description: ARM: dts: Add Exynos5250 Snow Rev5+ support > Applying: ARM: dts: Add Exynos5250 Snow Rev5+ support > .git/rebase-apply/patch:774: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > sigh, sorry for missing that one. > > One other nit is that the exynos5250-snow.dts" ends up with the > "max98095" pinctrl properties sorted differently than the > "exynos5250-snow-rev5.dts". Is it worth reordering the > "exynos5250-snow.dts" in the same patch? > Right, I'll change exynos5250-snow.dts to have pinctrl-names before pinctrl-0 that will not only match max98090 properties order but also be consistent with the rest of the dev nodes. > Otherwise this looks fine to me. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Thanks a lot for your feedback and review! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
