Hi Magnus, On Tue, Sep 29, 2015 at 3:30 PM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote: > On Tue, Sep 29, 2015 at 9:48 PM, Geert Uytterhoeven > <geert@xxxxxxxxxxxxxx> wrote: >> On Tue, Sep 22, 2015 at 5:44 PM, Geert Uytterhoeven >> <geert+renesas@xxxxxxxxx> wrote: >>> --- a/drivers/clk/shmobile/clk-rcar-gen2.c >>> +++ b/drivers/clk/shmobile/clk-rcar-gen2.c >>> @@ -431,7 +431,7 @@ static void __init rcar_gen2_cpg_clocks_init(struct device_node *np) >>> >>> of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data); >>> >>> - cpg_mstp_add_clk_domain(np); >>> + cpg_mssr_add_clk_domain(np); >> >> Of course this should become conditional on the presence of the new >> "renesas,r8a7791-cpg-mssr" compatible value, to preserve >> backwards-compatibility with old DTSes. > > Yeah, and we should probably link in both clk-mstp.o and clk-mssr.o > for older SoCs. Yep, been there, done that (local code updated and working ;-) The conditional in drivers/sh/pm_runtime.c is getting a bit too gory for my appetite. I think we should make PM (and thus PM_GENERIC_DOMAINS) mandatory. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html