Re: [PATCH v7 14/15] power: bq24257: Add platform data based initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On Fri, Sep 25, 2015 at 10:54:19AM -0500, Andreas Dannenberg wrote:
> The patch adds a way to setup and initialize the device through the use
> of platform data with configuration options equivalent to when using
> device firmware (DT or ACPI) for systems where this is not available.

Which board is this btw? Looks like most arm board code is going
away in the next few kernel releases, so I wonder if this patch
will just increase maintainence without any proper user.

> Signed-off-by: Andreas Dannenberg <dannenberg@xxxxxx>
> ---
>  drivers/power/bq24257_charger.c       | 39 +++++++++++++++++++++++++++++++++--
>  include/linux/power/bq24257_charger.h | 25 ++++++++++++++++++++++
>  2 files changed, 62 insertions(+), 2 deletions(-)
>  create mode 100644 include/linux/power/bq24257_charger.h
> 
> diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c
> index 19a0962..3b1a3b6 100644
> --- a/drivers/power/bq24257_charger.c
> +++ b/drivers/power/bq24257_charger.c
> @@ -27,10 +27,13 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/interrupt.h>
>  #include <linux/delay.h>
> +#include <linux/gpio.h>

You can drop this include. It's not needed with gpiod_*().

-- Sebastian

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux