Hi Sebastian, On Tue, Sep 22, 2015 at 11:29 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote: > Hi Marek, > > On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote: >> If either twl4030_charger or twl4030_madc is configured as MODULE, >> we get build (link) errors. >> >> To solve, the direct call of twl4030_get_madc_conversion() is replaced >> by a call to iio_read_channel_processed(). >> >> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> >> Signed-off-by: Marek Belisko <marek@xxxxxxxxxxxxx> >> --- >> changes from V1: added missing iio_channel_release + document and add new DT bindings > > That was fast :) Patchset looks fine to me except for one last > thing: Let's make the iio-channel optional, so that old DT blobs > are still supported. Also the IS_REACHABLE(CONFIG_TWL4030_MADC) > check can be removed, it should no longer be needed with > iio_read_channel_processed(). OK I updated driver code to pass when 'vac' property isn't found in DT. Should I mark it also in DT bindings or keep it as it was in v2? Thanks. > > -- Sebastian BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
