On 9/17/2015 6:16 PM, Florian Fainelli wrote: > On 17/09/15 16:57, Ray Jui wrote: >> This patch cleans up Cygnus DT files and makes the format consistent >> with the rest of Broadcom iProc based SoCs. >> >> Changes include: >> - Put core components into "core" node of type "simple-bus" >> - Put all other peripherals into "soc" node of type "simple-bus" >> - Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts >> files >> - Ordered all device nodes under buses based on their base register >> addresses >> - Remove unused PCI I/O resource >> - Use label instead of full path to reference device nodes in dts >> files > > I am fine with the changes per-se, but the review is made largely more > difficult because you mix multiple changes at the same time, this really > ought to be separate patches to ease the review process. Sorry for not > picking that up earlier. Sure! I'll break them up into individual patches as follows: - Put core components into "core" node of type "simple-bus" - Put all other peripherals into "soc" node of type "simple-bus" - Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts files - Ordered all device nodes under buses based on their base register addresses - Remove unused PCI I/O resources - Use label instead of full path to reference device nodes in dts files Thanks! Ray -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html