Hi Mike, Hi Stephen, On Tue, Aug 04, 2015 at 02:28:16PM +0200, Geert Uytterhoeven wrote: > Currently the CPG/MSTP Clock Domain code looks for MSTP clocks to power > manage a device. > > Unfortunately, on R-Mobile APE6 (r8a73a4) and SH-Mobile AG5 (sh73a0), > the Bus State Controller (BSC) is not power-managed by an MSTP clock, > but by a plain CPG clock (zb_clk). Add a special case to handle this, > so the clock is properly managed, and devices connected to the BSC work > as expected. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> for one reason or another I seem to have this patch queued up in my renesas tree for v4.4, without any Acks. I think it would be best if one of you took the patch instead. Though I'm also happy to take it with Acks. Let me know how you would like to proceed. > --- > v4: > - Add Reviewed-by, > > v3: > - Use "CPG/MSTP Clock Domain" instead of "CPG Clock Domain", > > v2: > - New. > --- > drivers/clk/shmobile/clk-mstp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/clk/shmobile/clk-mstp.c b/drivers/clk/shmobile/clk-mstp.c > index b1df7b2f1e970adb..a117c3f0f257b5e1 100644 > --- a/drivers/clk/shmobile/clk-mstp.c > +++ b/drivers/clk/shmobile/clk-mstp.c > @@ -259,6 +259,10 @@ int cpg_mstp_attach_dev(struct generic_pm_domain *domain, struct device *dev) > "renesas,cpg-mstp-clocks")) > goto found; > > + /* BSC on r8a73a4/sh73a0 uses zb_clk instead of an mstp clock*/ > + if (!strcmp(clkspec.np->name, "zb_clk")) > + goto found; > + > of_node_put(clkspec.np); > i++; > } > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
