Hi Mark, Thanks for taking a look. Mark Rutland <mark.rutland@xxxxxxx> writes: > On Mon, Sep 14, 2015 at 02:00:14PM +0100, Punit Agrawal wrote: >> The System Control Processor (SCP) provides access to SoC sensors via >> the System Control and Power Interface (SCPI) Message Protocol. Add >> bindings to allow probing of these sensors. Also support referencing >> of the sensors for setting up thermal zones via the thermal DT >> bindings. >> >> Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx> >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Cc: Mark Rutland <mark.rutland@xxxxxxx> >> Cc: Sudeep Holla <sudeep.holla@xxxxxxx> >> --- >> Documentation/devicetree/bindings/arm/arm,scpi.txt | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt b/Documentation/devicetree/bindings/arm/arm,scpi.txt >> index f002460..af66f7f 100644 >> --- a/Documentation/devicetree/bindings/arm/arm,scpi.txt >> +++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt >> @@ -72,8 +72,18 @@ Required sub-node properties: >> - compatible : should be "arm,juno-scp-shmem" for Non-secure SRAM based >> shared memory on Juno platforms >> >> +Sensor bindings for the sensors based on SCPI Message Protocol >> +-------------------------------------------------------------- >> +SCPI provides an API to access the various sensors on the SoC. >> + >> +Required properties: >> +- compatible : should be "arm,scpi-sensors". >> +- #thermal-sensor-cells: should be set to 1. This property follows the >> + thermal device tree bindings[2]. > > You need to specify what the valid values for this cell are. The enumeration depends on the number of sensors exported by SCP firmware - which is platform dependent. I could add add something like if you think that is helpful - "Valid cell value is a number between 0..n-1, where n is the number of sensors exported by SCP firmware." Thanks, Punit > > Mark. > >> + >> [0] http://infocenter.arm.com/help/topic/com.arm.doc.dui0922b/index.html >> [1] Documentation/devicetree/bindings/clock/clock-bindings.txt >> +[2] Documentation/devicetree/bindings/thermal/thermal.txt >> >> Example: >> >> @@ -122,6 +132,11 @@ scpi_protocol: scpi@2e000000 { >> clock-output-names = "pxlclk0", "pxlclk1"; >> }; >> }; >> + >> + scpi_sensors0: sensors { >> + compatible = "arm,scpi-sensors"; >> + #thermal-sensor-cells = <1>; >> + }; >> }; >> >> cpu@0 { >> -- >> 2.5.0 >> > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
