On Mon, Sep 14, 2015 at 06:51:36AM +0000, Yuantian Tang wrote: > The ARCH should have been ARM for this driver. > Do you think this warning would go away if adding a dependency on ARM? Yes, that may work. Thanks, Fengguang > > -----Original Message----- > > From: Fengguang Wu [mailto:fengguang.wu@xxxxxxxxx] > > Sent: Monday, September 14, 2015 12:05 PM > > To: Tang Yuantian-B29983 <Yuantian.Tang@xxxxxxxxxxxxx> > > Cc: Tejun Heo <tj@xxxxxxxxxx>; hdegoede@xxxxxxxxxx; linux- > > ide@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings > > > > Yuantian, > > > > It's cross compiling on ARCH=openrisc. > > > > Thanks, > > Fengguang > > > > On Mon, Sep 14, 2015 at 03:02:27AM +0000, Yuantian Tang wrote: > > > Hello Tejun, > > > > > > The toolchain I used is: > > > gcc version 4.8.3 20140401 (prerelease) (Linaro GCC 4.8-2014.04) > > > > > > I have not found this warning using this tool chain with -Wuninitialized flag. > > > > > > Regards, > > > Yuantian > > > > > > > -----Original Message----- > > > > From: Tejun Heo [mailto:htejun@xxxxxxxxx] On Behalf Of Tejun Heo > > > > Sent: Friday, September 11, 2015 9:55 PM > > > > To: Tang Yuantian-B29983 <Yuantian.Tang@xxxxxxxxxxxxx> > > > > Cc: hdegoede@xxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; linux- > > > > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Fengguang Wu > > > > <fengguang.wu@xxxxxxxxx> > > > > Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable > > > > warnings > > > > > > > > Hello, Yuantian. > > > > > > > > On Fri, Sep 11, 2015 at 05:27:25AM +0000, Yuantian Tang wrote: > > > > > Hi Tejun, > > > > > > > > > > Could you please take the version 1 patch? > > > > > The version 2 patch can't address these warnings, and the version > > > > > 1 can > > > > definitely remove them. > > > > > In this case, that would cause any hidden bugs, so no worries. > > > > > > > > Ugh... I really hate changes which are made to just work around > > > > compiler silliness. If this is something which goes away with newer > > > > gcc, Fengguang can just make it as a known false positive. > > > > Yuantian, which compiler are you using? > > > > > > > > Thanks. > > > > > > > > -- > > > > tejun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
