On Friday 11 September 2015 16:18:38 Chen Feng wrote: > +static int __init hi6220_reset_init(void) > +{ > + int ret; > + struct device_node *np; > + struct hi6220_reset_data *data; > + > + data = kzalloc(sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + np = of_find_compatible_node(NULL, NULL, "hisilicon,hi6220_reset_ctl"); > + if (!np) { > + ret = -ENXIO; > + goto err_alloc; > + } Why is this not a platform driver? > + if (IS_ENABLED(CONFIG_RESET_CONTROLLER)) > + reset_controller_register(&data->rc_dev); > + > + return 0; The Kconfig symbol already depends on RESET_CONTROLLER, so the IS_ENABLED() check looks redundant. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html