On 4 September 2015 at 14:00, Kishon Vijay Abraham I <kishon@xxxxxx> wrote: > vsel_reg and enable_reg of the pbias regulator descriptor should actually > have the offset from syscon. > > However after > "ARM: dts: <platform>: add minimal l4 bus layout with control module > support" > vsel_reg and enable_reg started to have the absolute address because > of address translation that happens due to pbias node made as the > child node of syscon. This breaks the pbias regulator enable. > > This series adds the 'offset' to be populated in vsel_reg and enable_reg > in the pbias driver itself. > > Changes from v2: > *) Squashed all the dt patches into a single patch > > Changes from v1: > *) Fixed Tony's review comments on adding a 'comment' for adding offset in > the driver and adding a warning for using platform_get_resource. > *) Added Tony's Acked-by. > > Tested these patches against mmc -next in omap4 panda, omap3 beagle xm, > dra72 and omap5 uevm > > Kishon Vijay Abraham I (2): > regulator: pbias: program pbias register offset in pbias driver > ARM: dts: <omap2/3/4/5/dra7>: use "ti,pbias-<platform>" compatible > string for pbias > > .../bindings/regulator/pbias-regulator.txt | 7 ++- > arch/arm/boot/dts/dra7.dtsi | 2 +- > arch/arm/boot/dts/omap2430.dtsi | 2 +- > arch/arm/boot/dts/omap3.dtsi | 2 +- > arch/arm/boot/dts/omap4.dtsi | 2 +- > arch/arm/boot/dts/omap5.dtsi | 2 +- > drivers/regulator/pbias-regulator.c | 56 +++++++++++++++++--- > 7 files changed, 61 insertions(+), 12 deletions(-) > > -- > 1.7.9.5 > Okay, just to be clear on the way forward. I spoked with Mark Brown offlist, and he will/has picked up the regulator patch and will send it as fix for the 4.3 rc[n]. Regarding the ARM patch here, I guess Tony might as well handle it and send through arm-soc, especially since the regression won't be fixed within my mmc tree anyway. So, I am going to leave my next branch as is - and thus relying on that the regression for OMAP will be fixed in some the 4.3 rc[n]. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
