W dniu 01.09.2015 o 21:18, Javier Martinez Canillas pisze: > Hello Krzysztof, > > On 09/01/2015 02:00 PM, Krzysztof Kozlowski wrote: >> W dniu 01.09.2015 o 17:48, Javier Martinez Canillas pisze: > > [snip] > >>>> >>>> &hsi2c_5 { >>>> status = "okay"; >>> >>> since I believe for the Odroid XU4 we would like this to be disabled. >>> The only I2C device in this I2C bus is the max98090 codec which is >>> not present in the XU4. >> >> hsi2c_5 and i2s_0 are not used by board directly but are connected to >> external connector: >> http://www.hardkernel.com/main/products/prdt_info.php?g_code=G143452239825&tab_idx=2 >> >> This is the 12pin GPIO/I2C/I2S connector in bottom-right corner of board >> view. >> > > Thanks for the info, I missed that. > >> This is why I left this and is2_0 enabled on Odroid XU4 - I assumed >> someone may connect something to it. However I have doubts if it is > > Yes, now it makes sense. > >> usable in such state: without respective addresses and interrupts. In >> the same time OF_OVERLAY should customize it properly. >> >> What do you think? >> > > As you said, these are not usable in the current form since if someone > wants to use it, has to add a dev node for the I2C device, possibly a > clock-frequency to change the default operating frequency, etc. > > So has to either create a new DTS based on exynos5422-odroidxu4.dts or > as you said use OF overlays. IMHO these should be left disabled and be > enabled by users when adding the needed stuff. Okay. I'll update the patch by moving entire hsi2c_5 node to audio DTSI (including "okay") and i2s0 thus disabling them on XU4. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html