On Thu, Aug 20, 2015 at 02:08:30PM -0700, Mark Brown wrote: > On Thu, Aug 20, 2015 at 09:34:33PM +0200, Maxime Ripard wrote: > > On Thu, Aug 20, 2015 at 11:41:32AM -0700, Mark Brown wrote: > > > On Thu, Aug 20, 2015 at 02:19:45PM -0000, Michal Suchanek wrote: > > > > > drivers/spi/spi-sun4i.c | 10 +++++++++- > > > > drivers/spi/spi-sun6i.c | 10 +++++++++- > > > > Are we *sure* we can't work on merging these drivers :( > > > Those are two different IPs, that don't really share anything but > > their author... > > I seem to be seeing a number of changes like this one which make > apparently very similar modifications to both. Perhaps there is more > core usage that should be happening instead? Yeah, because I wrote the two at the same time, and they share the same flaws. But that doesn't really mean that you can share anything at the driver level. And I'm not really sure that we can do much more at the framework level either, except maybe handling the timeout directly (but then the drivers would have to handle the recovering after a timeout too). Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
