On Thu, Aug 20, 2015 at 12:23:50PM +0530, Rameshwar Sahu wrote:
> Hi Vinod,
>
> On Thu, Aug 20, 2015 at 11:10 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> > On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote:
> >> + /* Invalidate unused source address field */
> >> + for (; i < 4; i++)
> >> + xgene_dma_invalidate_buffer(xgene_dma_lookup_ext8(desc2, i));
> >> +
> >> + /* Check whether requested buffer processed */
> >> + if (nbytes) {
> >> + chan_err(chan, "Src count crossed maximum limit\n");
> >> + return -EINVAL;
> > no cleanup ?
> Here not required, cleanup I am doing in parent function from where
> this function is getting called in case of failure.
> >
> >> +struct dma_async_tx_descriptor *xgene_dma_prep_flyby(
> >> + struct xgene_dma_chan *chan, struct scatterlist *src_sg,
> >> + size_t len, u32 seed, u8 *result, unsigned long flags, u8 opcode)
> > please fix style here
>
> Could you explain me What kind of coding style you would like here ??
See CodingStyle Chapter 2
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
