Hi Sjoerd, Am Mittwoch, 19. August 2015, 08:56:48 schrieb Sjoerd Simons: > Hey Heiko, > > Thanks for the comments, i'm hoping to address them and Marks comments > in a next patch series next week. > > On Tue, 2015-08-18 at 20:25 +0200, Heiko Stuebner wrote: > > > + > > > + spdif->hclk = devm_clk_get(&pdev->dev, "spdif_hclk"); > > > > I guess this could be named just "hclk" - as it is the identifier > > local to the spdif-ip. (Of course in the binding too) > > I'm entirely happy to change that, just wanted to note that the reason > i used spdif_hclk and spidf_clk is for consistency with the rockchip > -i2s binding which uses i2s_hclk ans i2s_mclk. I was also just remembering something Thierry Reding said in the edp thread: "The names are in a per-driver scope, so "dp-phy" is implied by the device tree binding and driver already. You could simply use shorter names such as "phy" and "24m" for example." > However i guess we could update the i2s binding at some poit as well to > follow similar names (with fallbacks to the old one). In general a lot > of the comments yourself and Mark have given actually apply to the > rockchip-i2s code as well so there is some cleanup to do there :) I'm not sure about updating the binding though, as it we'd need to provide backwards-compatibility for the old names as well. So I don't think renaming these will bring much benefit, but we can choose better names for followup drivers like the spdif. I haven't looked to much into the i2s stuff yet. But with me getting a grasp on the fractional dividers and the hardware drivers making it into the asoc tree now, I also plan to give the i2s audio on the Chromebooks a try :-) Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
