On Tue, Aug 18, 2015 at 10:48 AM, Adrian Alonso <aalonso@xxxxxxxxxxxxx> wrote:
> iMX7D has two iomuxc controllers, iomuxc controller similar as
> previous iMX SoC generation and iomuxc-lpsr which provides low
> power state rentetion capabilities on gpios that are part of
> iomuxc-lpsr
>
> - Add iomuxc-lpsr gpio group id's
> - Use flag ZERO_OFFSET_VALID and SHARE_INPUT_SELECT_REG to
> properly set pads from iomuxc-lpsr domain
>
> Signed-off-by: Adrian Alonso <aalonso@xxxxxxxxxxxxx>
> ---
> drivers/pinctrl/freescale/pinctrl-imx7d.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx7d.c b/drivers/pinctrl/freescale/pinctrl-imx7d.c
> index 1fa7530..a347c22 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx7d.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx7d.c
> @@ -172,6 +172,14 @@ enum imx7d_pads {
> MX7D_PAD_ENET1_RX_CLK = 152,
> MX7D_PAD_ENET1_CRS = 153,
> MX7D_PAD_ENET1_COL = 154,
I suggest use new enum. like imx7d_lpsr_pads
to avoid confuse about duplicate 0 - 7.
best regards
Frank Li
> + MX7D_PAD_GPIO1_IO00 = 0,
> + MX7D_PAD_GPIO1_IO01 = 1,
> + MX7D_PAD_GPIO1_IO02 = 2,
> + MX7D_PAD_GPIO1_IO03 = 3,
> + MX7D_PAD_GPIO1_IO04 = 4,
> + MX7D_PAD_GPIO1_IO05 = 5,
> + MX7D_PAD_GPIO1_IO06 = 6,
> + MX7D_PAD_GPIO1_IO07 = 7,
> };
>
> /* Pad names for the pinmux subsystem */
> @@ -333,13 +341,32 @@ static const struct pinctrl_pin_desc imx7d_pinctrl_pads[] = {
> IMX_PINCTRL_PIN(MX7D_PAD_ENET1_COL),
> };
>
> +/* Pad names for the pinmux subsystem */
> +static const struct pinctrl_pin_desc imx7d_lpsr_pinctrl_pads[] = {
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO00),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO01),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO02),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO03),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO04),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO05),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO06),
> + IMX_PINCTRL_PIN(MX7D_PAD_GPIO1_IO07),
> +};
> +
> static struct imx_pinctrl_soc_info imx7d_pinctrl_info = {
> .pins = imx7d_pinctrl_pads,
> .npins = ARRAY_SIZE(imx7d_pinctrl_pads),
> };
>
> +static struct imx_pinctrl_soc_info imx7d_lpsr_pinctrl_info = {
> + .pins = imx7d_lpsr_pinctrl_pads,
> + .npins = ARRAY_SIZE(imx7d_lpsr_pinctrl_pads),
> + .flags = SHARE_INPUT_SELECT_REG | ZERO_OFFSET_VALID,
> +};
> +
> static struct of_device_id imx7d_pinctrl_of_match[] = {
> { .compatible = "fsl,imx7d-iomuxc", .data = &imx7d_pinctrl_info, },
> + { .compatible = "fsl,imx7d-iomuxc-lpsr", .data = &imx7d_lpsr_pinctrl_info },
> { /* sentinel */ }
> };
>
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
