From: Kenneth Lee <liguozhu@xxxxxxxxxxxxx> Date: Fri, 14 Aug 2015 18:30:19 +0800 > diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c > new file mode 100644 > index 0000000..fd09768 > --- /dev/null > +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c ... > +static inline void hnae_list_add(spinlock_t *lock, struct list_head *node, > + struct list_head *head) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(lock, flags); > + list_add_tail_rcu(node, head); > + spin_unlock_irqrestore(lock, flags); > +} Do not declare functions 'inline' in foo.c files, let the compiler decide on it's own. This applies to your entire patch series. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html