On 17/08/15 16:27, Andrew Lunn wrote: > On Mon, Aug 17, 2015 at 03:11:48PM +0300, Tomi Valkeinen wrote: >> Hi Andrew, (and Brian), (Sorry for typoing your name, Bryan =). >> On 18/03/15 00:08, Andrew Lunn wrote: >>> This patchset is a driver for the TI tlc59116 16 Channel i2c LED >>> driver and tlc59108 8 Channel i2c LED driver. This driver is used on >>> the Belkin WRT1900AC access point and the C code is derived from code >>> Belkin contributed to OpenWRT. However it has been extensively >>> re-written, and a device tree binding added to replace platform data. >> >> I see this is now in 4.2-rc... And I see you dropped me from Cc in this >> resend series. Because of that, I missed this resend, and couldn't >> object to merging. >> >> I'm not very happy about this getting merged. I think I had valid >> comments to the driver, to which I did get no answers. You knew my >> objections, but you did not even bother mentioning those in the resend >> intro. > > Hi Tomi > > Our discussions were going around in circles, no progress being made. > The subsystem maintainer is ultimately the one who needs to decide, > bar Linus himself. Bryan Wu has seen all the discussions, and > ultimately decided the driver was O.K, despite any unresolved issues > you might have. If so, Bryan did not comment to the unanswered questions in any way. More probable is that he missed them. It's not easy as a maintainer to follow all the discussions on the various threads. It's your responsibility as the sender of the patches to make sure all the relevant information is available for the maintainer. > If you think your PWM code is so much better, please submit a revert > patch plus your PWM LED driver. We can find somebody to do a side by > side review. It's not about the driver code. That can be cleaned up if needed. The question is whether the driver should be a PWM driver or a LED driver. My question to you was that if this driver would be a PWM driver, and you would use pwm-leds to implement the led functionality, would that cover your use case? We use the chip as a PWM device, for backlight, and also as a GPIO expander. A PWM driver makes sense in our case. If it also works fine for your use case, then isn't a PWM driver better option? Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
