Re: [PATCH v4 1/6] mfd: fsl imx25 Touchscreen ADC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Jun 27, 2014 at 11:18 AM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Jun 24, 2014 at 4:46 PM, Denis Carikli <denis@xxxxxxxxxx> wrote:

>> +       irq_set_chip_and_handler(irq, &dummy_irq_chip,
>> +                                handle_level_irq);
>> +       set_irq_flags(irq, IRQF_VALID);
>
> This function only exists on ARM. Unless Kconfig ensures
> this is only available on ARM platforms, use
>
> #ifdef CONFIG_ARM
>       set_irq_flags(irq, IRQF_VALID);
> #else
>       irq_set_noprobe(irq);
> #endif
>
> (Sorry we have no better way of doing it.)

Since I wrote this, there have been cleanups from Rob Herring merged
to the kernel to get rid of this oddity. Please check in linux-next how
to get this right, see c.f. commit
e8d36d5dbb6a6ec4f5222f8775d664ec29d5527d
"ARM: kill off set_irq_flags usage"

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux