On Friday 14 August 2015 18:30:18 Kenneth Lee wrote: > diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt > new file mode 100644 > index 0000000..5ab6969 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt > @@ -0,0 +1,14 @@ > +Hisilicon Network Subsystem NIC controller > + > +Required properties: > +- compatible: hisilicon,hns-nic > +- ae-name: accelerator name who provide this interface > +- ae-opts: options (string) to the accelerator. e.g. the index interface > + > +Example: > + > + ethernet@0{ > + compatible = "hisilicon,hns-nic"; > + ae-name = "soc0-n4"; > + ae-opts = "0"; > + }; > These properties look very unconventional. What are the valid strings for ae-name and ae-opts? It looks like the latter is just a number, so why not use an integer property? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html