On Tue, Aug 4, 2015 at 2:22 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Monday 03 August 2015 01:53:23 Kuninori Morimoto wrote:
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -0,0 +1,93 @@
>> +/ {
>> + clocks {
>
> Let's try to make it right from the start on Gen3. The CPG node should be a
> direct child of the bus node mentioned above, and the MSTP clocks should be
> children of the CPG node.
Agreed.
> I'm not sure where to put the non-memory-mapped clocks though, should they be
> directly under the root node ? It would make sense for extal_clk, but how
> about the fixed-factor clocks ? Should they be children of the CPG node too ?
I believe the current trend is to put clocks like "extal_clk" under the root
node.
As the fixed-factor clocks are generated by the CPG module, and we do have
a device node for it, I'd make them children of the CPG node, too.
Any comments from the clk+dt experts?
Thanks!
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + extal_clk: extal_clk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <0>;
>> + clock-output-names = "extal";
>> + };
>> + cpg_clocks: cpg_clocks@e6150000 {
>> + compatible = "renesas,r8a7795-cpg-clocks",
>> + "renesas,rcar-gen3-cpg-clocks";
>> + reg = <0 0xe6150000 0 0x1000>;
>> + clocks = <&extal_clk>;
>> + #clock-cells = <1>;
>> + clock-output-names = "main", "pll0", "pll1","pll2",
>> + "pll3", "pll4";
>> + };
>> + p_clk: p_clk {
>> + compatible = "fixed-factor-clock";
>> + clocks = <&cpg_clocks RCAR_GEN3_CLK_PLL1>;
>> + #clock-cells = <0>;
>> + clock-div = <24>;
>> + clock-mult = <1>;
>> + clock-output-names = "p";
>> + };
>> + mstp3_clks: mstp3_clks@e615013c {
>> + compatible = "renesas,r8a7795-mstp-clocks",
>> + "renesas,cpg-mstp-clocks";
>> + reg = <0 0xe615013c 0 4>, <0 0xe6150048 0 4>;
>> + clocks = <&p_clk>;
>> + #clock-cells = <1>;
>> + renesas,clock-indices = <RCAR_GEN3_CLK_IRDA>;
>> + clock-output-names = "irda";
>> + };
>> + };
>> +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
