Hi Paul, On Tue, Aug 04, 2015 at 04:49:30PM +0800, Leo Yan wrote: > On Tue, Aug 04, 2015 at 10:30:24AM +0200, Paul Bolle wrote: > > (This RFC was part of this mornings catch of my crude mail filter. So, > > for what it's worth, what follows are a few random comments for the few > > things I'm able to spot.) [...] > > > +static int __init hi6220_mbox_init(void) > > > +{ > > > + return platform_driver_register(&hi6220_mbox_driver); > > > +} > > > +module_init(hi6220_mbox_init); > > > + > > > +static void __exit hi6220_mbox_exit(void) > > > +{ > > > + platform_driver_unregister(&hi6220_mbox_driver); > > > +} > > > +module_exit(hi6220_mbox_exit); > > > > This could be flattened into one line: > > module_platform_driver(hi6220_mbox_driver); Need clarify one thing: will modify to use core_initcall() for driver's initialization; due another clock driver depends on this mailbox driver, so mailbox init firstly with core_initcall() and use subsys_initcall() for clock driver. Thanks, Leo Yan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html