Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> On Mon, 27 Jul 2015, Eric Anholt wrote:
>> +/* Unmasks the IPI on the CPU wen it's first brought online. */
>
> when
>
>> +static int bcm2836_arm_irqchip_cpu_notify(struct notifier_block *nfb,
>> + unsigned long action, void *hcpu)
>> +{
>> + unsigned int cpu = (unsigned long)hcpu;
>> + unsigned int int_reg = LOCAL_MAILBOX_INT_CONTROL0;
>> + unsigned int mailbox = 0;
>> +
>> + if (action == CPU_STARTING || action == CPU_STARTING_FROZEN)
>> + bcm2836_arm_irqchip_unmask_per_cpu_irq(int_reg, mailbox, cpu);
>
> Shouldn't you mask the irq on CPU_DYING?
I was just following what other drivers were doing. Is CPU_DYING the
only thing that needs masking?
Attachment:
signature.asc
Description: PGP signature
