Hi Mauro, Thanks for reviewing. Sending my reply again, as it looks like I dropped the CC list on my first reply, and my second reply bounced on the mailing lists :-( On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote: > Em Wed, 24 Jun 2015 16:11:09 +0100 > Peter Griffin <peter.griffin@xxxxxxxxxx> escreveu: > > > This patch adds the Kconfig and Makefile for the c8sectpfe driver > > so it will be built. It also selects additional demodulator and tuners > > which are required by the supported NIM cards. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > --- > > drivers/media/Kconfig | 1 + > > drivers/media/Makefile | 1 + > > drivers/media/tsin/c8sectpfe/Kconfig | 26 ++++++++++++++++++++++++++ > > drivers/media/tsin/c8sectpfe/Makefile | 11 +++++++++++ > > 4 files changed, 39 insertions(+) > > create mode 100644 drivers/media/tsin/c8sectpfe/Kconfig > > create mode 100644 drivers/media/tsin/c8sectpfe/Makefile > > > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > > index 1570992..82bc1dc 100644 > > --- a/drivers/media/Kconfig > > +++ b/drivers/media/Kconfig > > @@ -170,6 +170,7 @@ source "drivers/media/pci/Kconfig" > > source "drivers/media/platform/Kconfig" > > source "drivers/media/mmc/Kconfig" > > source "drivers/media/radio/Kconfig" > > +source "drivers/media/tsin/c8sectpfe/Kconfig" > > > > comment "Supported FireWire (IEEE 1394) Adapters" > > depends on DVB_CORE && FIREWIRE > > diff --git a/drivers/media/Makefile b/drivers/media/Makefile > > index e608bbc..0a567b8 100644 > > --- a/drivers/media/Makefile > > +++ b/drivers/media/Makefile > > @@ -29,5 +29,6 @@ obj-y += rc/ > > # > > > > obj-y += common/ platform/ pci/ usb/ mmc/ firewire/ > > +obj-$(CONFIG_DVB_C8SECTPFE) += tsin/c8sectpfe/ > > Hmm... why are you adding it at a new "tsin" directory? We're putting > those SoC platform drivers under platform/. I didn't realise that. I will move this under there in the V2 patchset then? The rationale behind a new 'tsin' directory was that all the current DVB drivers seemed to be grouped by the underlying bus on which TS data enters the system (e.g. pci / usb). As this didn't fit in with that scheme I created a new tsin directory for SoC's which have dedicated hardware for Transport Stream INput (tsin) into the SoC. regards, Peter. p.s. Mauro - appologies again for spaming you -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
