Hello Michal, The patch looks good to me, just one small comment below. On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@xxxxxxxxx> wrote: > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek <hramrach@xxxxxxxxx> > > -- > v2 > - don't move unrelated line > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..62be08a 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 0>; NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or Krzysztof can fixup when applying it? > }; > > &usbdrd_dwc3 { > -- Acked-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html