On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote: > Here we apply required documentation for the imx6ul touch screen > controller driver which describe available properties and how to > use them. > > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > new file mode 100644 > index 0000000..e34d752 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > @@ -0,0 +1,14 @@ > +* Freescale i.MX6UL Touch Controller > + > +Required properties: > +- compatible: must be "fsl,imx6ul-tsc" > + What about all the other properties in the example? > +Example: > + &tsc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_tsc>; > + status = "okay"; > + xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>; > + measure_delay_time = <0xfff>; > + pre_charge_time = <0xffff>; Thiose underscores should be dashes, and all the properties should be documented. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html