On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong@xxxxxxxxxx> wrote: > On 2015/7/25 3:00, Rob Herring wrote: >> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@xxxxxxxxxx> wrote: >>> Update the last pr_warning callsite in drivers/of. >> >> That is obvious in the diff, but can you tell me why? > > Hi Rob, > > When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning > will produce WARNING: > > WARNING: Prefer pr_warn(... to pr_warning(... > #22: FILE: drivers/of/fdt.c:428: > + pr_warning("End of tree marker overwritten: %08x\n", > > So,we should convert pr_warning to pr_warn. Okay, but don't explain to me. Explain this in the commit message. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html