On Fri, Jul 24, 2015 at 02:14:57PM -0500, Rob Herring wrote:
> On Fri, Jul 24, 2015 at 1:26 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > Sometimes drivers might wish to transition from index-based to named
> > interrupt descriptions. To aid in decision-making when parsing device
> > tree data let's provide a helper that will indicate the scheme that is
> > being used.
>
> Generally, IRQs are retrieved by platform_get_irq or
> platform_get_irq_byname. Drivers should not call the of_irq_*
> functions directly in most cases.
That would be true for platform drivers, but not all devices are
platform devices.
>
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > ---
> >
> > The intent is to it like this:
> >
> > if (of_has_named_irqs(np) {
> > /* Wake IRQ is optional */
> > dev->wakeirq = of_irq_get_byname(np, "wakeup");
> > if (dev->wakeirq < 0 && dev->wakeirq != -ENODATA)
> > return dev->wakeirq;
> > }
>
> of_irq_get_byname will already return an error if the property is not
> present. Use that.
I do not like that it returns -EINVAL when property is missing, can we
change it to return -ENODATA (so it is the same as when the property is
defined but such name is missing)?
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
