Hi Will, > -----Original Message----- > From: linux-arm-msm-owner@xxxxxxxxxxxxxxx [mailto:linux-arm-msm- > owner@xxxxxxxxxxxxxxx] On Behalf Of Will Deacon > Sent: Tuesday, July 21, 2015 8:31 PM > To: Sricharan R > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; > mitchelh@xxxxxxxxxxxxxx > Subject: Re: [RFC PATCH 3/4] iommu/arm-smmu: Add support for specifying > clocks > > On Fri, Jul 17, 2015 at 05:53:24PM +0100, Sricharan R wrote: > > From: Mitchel Humpherys <mitchelh@xxxxxxxxxxxxxx> > > > > On some platforms with tight power constraints it is polite to only > > leave your clocks on for as long as you absolutely need them. > > Currently we assume that all clocks necessary for SMMU register access > > are always on. > > You've borrowed this commit message from Mitch's previous version of this > patch, but now you leave the clocks enabled most of the time so it doesn't > make much sense anymore. > Sorry, I should have changed that to make it clear. > Anyway, I'm OK with this kind of clock management in the driver, but I think > that anything more fine-grained needs to be designed into the IOMMU core. > Ok. Tried this to get the right direction. I will check for the power savings and if there are not much then I would use the above approach. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html