Hello Lee,
Thanks for your feedback.
On 07/23/2015 05:16 PM, Lee Jones wrote:
> On Fri, 17 Jul 2015, Javier Martinez Canillas wrote:
>
>> The MAX77802 is a chip that contains regulators, 2 32kHz clocks,
>> a RTC and an I2C interface to program the individual components.
>>
>> The are already DT bindings for the regulators and clocks and
>> these reference to a bindings/mfd/max77802.txt file, that didn't
>> exist, for the details about the PMIC.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>>
>> ---
>>
>> Changes in v2:
>> - Use the correct "maxim,max77802" compatible string.
>> Suggested by Krzysztof Kozlowski
>> - Use a pmic generic node name for the max77802 node example.
>> Suggested by Sergei Shtylyov.
>>
>> Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
>> new file mode 100644
>> index 000000000000..c60cdec50d36
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/max77802.txt
>> @@ -0,0 +1,26 @@
>> +Maxim MAX77802 multi-function device
>> +
>> +The Maxim MAX77802 is a power management chip (PMIC) that contains 10 high
>> +efficiency Buck regulators, 32 Low-dropout (LDO) regulators used to power
>
> Would be good to capitalise the works in the acronyms, so
> "Low-DropOut" and "Power Management IC".
>
Ok.
>> +up application processors and peripherals, a 2-channel 32kHz clock outputs,
>> +a Real-Time-Clock (RTC) and a I2C interface to program the individual
>> +regulators, clocks outputs and the RTC.
>> +
>> +Binding for the built-in 32k clock generator block is defined separately
>> +in the bindings/clk/maxim,max77802.txt file and binding for the regulators
>
> s/bindings/../
>
Ok.
>> +is defined in the bindings/regulator/max77802.txt file.
>> +
>> +Required properties:
>> +- compatible : Must be "maxim,max77802";
>> +- reg : Specifies the i2c slave address of PMIC block.
>
> s/i2c/I2C/
>
>> +- interrupts : This i2c device has an IRQ line connected to the main SoC.
>
> As above.
>
Ok. I'll change it.
>> +- interrupt-parent : The parent interrupt controller.
>> +
>> +Example:
>> +
>> + max77802: pmic@09 {
>> + compatible = "maxim,max77802";
>> + interrupt-parent = <&intc>;
>> + interrupts = <26 0>;
>
> Is there a define in include/dt-bindings/interrupt-controller to
> replace 0? IRQ_TYPE_NONE perhaps.
>
Yes, I'll change that as well.
>> + reg = <0x09>;
>> + };
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
