Stephen Warren <swarren@xxxxxxxxxxxxx> writes: > On 07/13/2015 07:35 PM, Eric Anholt wrote: >> The BCM2836 (Raspberry Pi 2) uses two levels of interrupt handling >> with the CPU-local interrupts being the root, so we need to register >> ours as chained off of the CPU's local interrupt. > > Sorry for the slow review; laziness after vacation! > >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > >> +The BCM2836 contains the same interrupt controller with the same >> +interrupts, but the per-CPU interrupt controller is the root, and an >> +interrupt there indicates that the ARMCTRL has an interrupt to handle. >> + >> Required properties: >> >> - compatible : should be "brcm,bcm2835-armctrl-ic" > > Since there are some differences between the bcm2835 and bcm2836 HW > blocks, I'd expect the compatible value to be different for each. In > particular... Well, there are actually no differences within this block of the HW (HDL is unmodified), it's just where the output interrupt line gets consumed. But it's not much extra to add a new compatible value, so sure.
Attachment:
signature.asc
Description: PGP signature
