On Tue, 2015-07-14 at 15:39 +0800, Daniel Kurtz wrote: > Hi Yingjoe, > > On Mon, Jul 13, 2015 at 5:32 PM, Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx> wrote: > > Spurious mtk timer interrupt is noticed at boot and cause kernel > > crash. It seems if GPT is enabled, it will latch irq status even > > when its IRQ is disabled. When irq is enabled afterward, we see > > spurious interrupt. > > Change init flow to only enable GPT_CLK_SRC at mtk_timer_init. > > > > Signed-off-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx> > > --- > > drivers/clocksource/mtk_timer.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > > index 68ab423..237c20b 100644 > > --- a/drivers/clocksource/mtk_timer.c > > +++ b/drivers/clocksource/mtk_timer.c > > @@ -156,9 +156,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt) > > writel(0x3f, evt->gpt_base + GPT_IRQ_ACK_REG); > > } > > > > -static void > > -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > > +static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, > > + u8 option, bool enable) > > This function can be: __init > > Other than this tiny nit, and the small potential conflict in patch 4, > this whole series is: > > Reviewed-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx> > > (I do think it is a bit strange that the mediatek,mt6577-timer binding > does not use "clock-names", but that is independent of this patch > set). > Hi Daniel, Thanks for your review. I added __init as you suggested, and Pi-Cheng already sent an updated version of his patch to resolve the conflict[1]. Joe.C [1] http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001592.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
