Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks Stefan,

On 21/07/15 17:25, Stefan Wahren wrote:
+
>+ addr = of_get_property(cell_np, "reg", &len);
>+ if (!addr || (len < 2 * sizeof(int))) {
I'm not sure, but shouldn't be sizeof(u32) more portable?

yes it makes sense, I will change it.
>[...]
>+
>+ addr = of_get_property(cell_np, "bits", &len);
>+ if (addr && len == (2 * sizeof(int))) {
dito
yep.

--srini
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux