Dear Mark,
Thanks a lot for so quick review!
On Tue, 21 Jul 2015 15:34:26 +0100
Mark Rutland <mark.rutland@xxxxxxx> wrote:
> Hi,
>
> > +/dts-v1/;
> > +
> > +/memreserve/ 0x00000000 0x01000000;
>
> What's this reservation for?
This is reserved for some firmwares' usage.
>
> Given you're using PSCI I can't see why we'd expect the kernel to map
> but not use some memory.
Is it acceptable that we make memory start at 0x01000000 instead of reservation?
>
> > +
> > +#include "berlin4ct.dtsi"
> > +
> > +/ {
> > + model = "MARVELL BG4CT DMP BOARD";
> > + compatible = "marvell,berlin4ct-dmp", "marvell,berlin4ct", "marvell,berlin";
> > +
> > + chosen {
> > + bootargs = "earlyprintk";
> > + stdout-path = "serial0:115200n8";
> > + };
>
> You shouldn't need those bootargs; "earlyprintk" does nothing on arm64.
will fix in a newer version
>
> [...]
>
> > + gic: interrupt-controller@901000 {
> > + compatible = "arm,gic-400";
> > + #interrupt-cells = <3>;
> > + interrupt-controller;
> > + reg = <0x901000 0x1000>,
> > + <0x902000 0x1000>,
> > + <0x904000 0x2000>,
> > + <0x906000 0x2000>;
> > + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> > + };
> > +
>
> I believe the size of the cpu interface (the second reg entry) should be
> 0x2000, as GICC_DIR is at offset 0x1000.
Oh, Yes! Thanks for pointing this out.
>
> Otherwise this looks fine.
>
> Thanks,
> Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
