Hi Steve,
it looks mostly good, a few more comments:
On 21/07/2015 at 10:43:10 +0100, S Twiss wrote :
> - if (val & (DA9063_E_ALARM))
> + if (val & (config->rtc_event_alarm_mask))
unneeded parenthesis here
> + if (of_device_is_compatible(pdev->dev.of_node, "dlg,da9063-rtc")) {
> + struct da9063 *chip = dev_get_drvdata(pdev->dev.parent);
> +
> + if (chip->variant_code == PMIC_DA9063_AD)
> + rtc->config = &da9063_ad_regs;
> + } else
> + rtc->config = match->data;
Both arms of the if should use braces.
Also, what happens if it is a da9063, BB variant? I guess rtc->config
will not be set.
maybe you should write:
rtc->config = match->data;
if (of_device_is_compatible(pdev->dev.of_node, "dlg,da9063-rtc")) {
struct da9063 *chip = dev_get_drvdata(pdev->dev.parent);
if (chip->variant_code == PMIC_DA9063_AD)
rtc->config = &da9063_ad_regs;
}
> @@ -348,5 +515,5 @@ module_platform_driver(da9063_rtc_driver);
>
> MODULE_AUTHOR("S Twiss <stwiss.opensource@xxxxxxxxxxx>");
> MODULE_DESCRIPTION("Real time clock device driver for Dialog DA9063");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
This should be part of the license change.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
