Hi Ivan, Thnaks for all the reviews. > -----Original Message----- > From: linux-arm-msm-owner@xxxxxxxxxxxxxxx [mailto:linux-arm-msm- > owner@xxxxxxxxxxxxxxx] On Behalf Of Ivan T. Ivanov > Sent: Monday, July 20, 2015 1:55 PM > To: Sricharan R > Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; > galak@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > i2c@xxxxxxxxxxxxxxx; agross@xxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH V4 2/7] qup: i2c: factor out common code for reuse > > > Hi Sricharan, > > On Thu, 2015-07-09 at 08:55 +0530, Sricharan R wrote: > > > > > static int qup_i2c_read_one(struct qup_i2c_dev *qup, struct i2c_msg > > *msg) { > > - unsigned long left; > > - int ret; > > + int ret = 0; > > > > - qup->msg = msg; > > - qup->pos = 0; > > + /* > > + * The QUP block will issue a NACK and STOP on the bus when > reaching > > + * the end of the read, the length of the read is specified as one > byte > > + * which limits the possible read to 256 (QUP_READ_LIMIT) bytes. > > + */ > > + if (msg->len > QUP_READ_LIMIT) { > > + dev_err(qup->dev, "HW not capable of reads over %d bytes\n", > > + QUP_READ_LIMIT); > > + return -EINVAL; > > + } > > > > This should be removed. Please see qup_i2c_quirks. > Ok get it, will remove this. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
