On Mon, Jul 20, 2015 at 10:51 PM, Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx> wrote: > > Hi Daniel, Chunfeng, > > > On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote: >> Hi, >> >> On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote: > <...> >> > > + >> > > + usb_p1_vbus: fixedregulator@0 { >> > >> > Why @0 ? >> It is the first fixed regulator, so set it to 0 as a index. >> I will remove it later > > Since this name should be unique, I think we should use gpio number as > address for fixedregulator in case we need other fixedregulators. So > this could be: > > usb_p1_vbus: fixedregulator@130 { > > Also, we should sort according to the address(gpio number) for these > nodes. Does this make sense? Yes - that makes some sense. But, a quick check of other "fixedregulator@" nodes in arch/arm/boot/dts/ shows that mostly they use @0 , @1. So, I think the original patch is probably fine. Sorry for the noise, -Dan > > Joe.C > >> > >> > > + compatible = "regulator-fixed"; >> > > + regulator-name = "usb_vbus"; >> > > + regulator-min-microvolt = <5000000>; >> > > + regulator-max-microvolt = <5000000>; >> > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; >> > > + enable-active-high; >> > > + }; > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html