Hi Paul, I've removed the ".bus = &plaform_bus_type" for the next series. Thank you for the explanation and the review :) Best Regards, Cyrille Le 17/07/2015 11:04, Paul Bolle a écrit : > On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote: >> --- /dev/null >> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c > >> +static struct platform_driver atmel_qspi_driver = { >> + .driver = { >> + [...] >> + .bus = &platform_bus_type, >> + [...] >> +}; >> +module_platform_driver(atmel_qspi_driver); > > Nit: on module init this will basically do > __platform_driver_register(&atmel_qspi_driver, THIS_MODULE); > > which will again set bus to &platform_bus_type. So you might as well > drop that line. > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html