On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote:
+ i2c->reg_base = devm_ioremap_resource(&dev->dev, res);
+ if (IS_ERR(i2c->reg_base)) {
+ dev_err(&dev->dev, "failed to map resource: %ld\n",
+ PTR_ERR(i2c->reg_base));
+ return PTR_ERR(i2c->reg_base);
+ }
One change I did when applying: removed this error message.
devm_ioremap_resource prints out the errors it finds.
devm_ioremap_resource doesn't print return value.
So this additional error message would print one of, -EINVAL, -EBUSY
or -ENOMEM.
That was the reason I kept it.
If you feel it is not required, I am OK to remove it.
Thanks for the update, it certainly saved one more version :) .
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html