On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong <gregory.0xf0@xxxxxxxxx> wrote: > If a failure occurs during probe, brcmstb_gpio_remove() is called. In > remove, we call platform_get_drvdata(), but at the time of failure in > the probe the driver data hadn't yet been set which leads to a NULL > ptr dereference in the remove's list_for_each. Call > platform_set_drvdata() and set up list head right after allocating the > priv struct to both avoid the null pointer dereference that could > occur today. To guard against potential future changes, check for > null pointer in remove. > > Reported-by: Tim Ross <tross@xxxxxxxxxxxx> > Signed-off-by: Gregory Fong <gregory.0xf0@xxxxxxxxx> > --- > New in v3. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
