A question and a nit follow. On vr, 2015-07-10 at 19:17 +0800, Jianwei Wang wrote: > --- /dev/null > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +MODULE_ALIAS("platform:fsl-dcu-drm"); Question: this appears to be only useful if there's a corresponding struct platform_device. That is, a platform_device with a "fsl-dcu-drm" .name. It will fire off a "MODALIAS=platform:fsl-dcu-drm" uevent when it's created. I couldn't find this corresponding platform_device. Does it exist? Or is this alias needed for some other reason? > --- /dev/null > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h > +#define DRIVER_NAME "fsl-dcu-drm" Nit: I don't think DRIVER_NAME is actually used anywhere. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html