On Thursday 09 July 2015 05:59 AM, Peter Hurley wrote: > Hi Sekhar, > > On 07/06/2015 05:47 AM, Sekhar Nori wrote: >> updating mdr1 register on OMAP needs to take care of >> errata i202. Introduce a function to update mdr1. >> >> This will be useful later on when mdr1 needs to be >> written to from other places. No functional change. > > This changelog is not clear. May I suggest: > > serial: 8250_omap: Refactor MDR1 update > > The errata [1] workaround implemented in follow-on patch, > "serial: 8250_omap: workaround errata on disabling UART after using DMA", > requires MDR1 register programming. > > Extract MDR1 register update into helper function, omap8250_update_mdr1(). > > [1] Advisory 21 in http://www.ti.com/lit/er/sprz408b/sprz408b.pdf Alright, will use this description instead. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html