Hello Krzysztof, On 07/08/2015 01:29 AM, Krzysztof Kozlowski wrote: > On 08.07.2015 14:36, Javier Martinez Canillas wrote: >> A previously defined Device Tree node, can be extended either by defining >> a node using the same full path or by creating a label for the node and >> referencing to it. >> >> Using full paths is more error prone since if there was a typo error, a >> new node will be created instead of extending the node as it was desired. >> This will lead to run-time errors that could be hard to detect. >> >> A misstyped label on the other hand, will cause a dtc compile error which > > s/misstyped/mistyped/ > sigh, it's so ironic that I mistyped that. Do you want me to re-post the whole series with the typo fixed or you / Kukjin would fix in both patches when applying? >> makes it easier to detect the mistake since happens at build-time instead. >> >> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> --- >> >> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 1600 ++++++++++++++--------------- >> 1 file changed, 799 insertions(+), 801 deletions(-) >> > > I didn't look carefully enough to call it a review (I trust the 'diff' > of yours) but it seems fine to me: > > Acked-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > Thanks a lot for. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Sr. Linux Kernel Developer Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
