On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote: > On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen <koro.chen@xxxxxxxxxxxx> wrote: > > This adds afe (audio front end) device node to the MT8173 dtsi file. > > > > This patch is based on Matthias's tree: > > https://github.com/mbgg/linux-mediatek > > branch: v4.2-next/arm64 > > > > Signed-off-by: Koro Chen <koro.chen@xxxxxxxxxxxx> > > --- > > > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 > > ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -14,6 +14,7 @@ > > > > #include <dt-bindings/clock/mt8173-clk.h> > > #include <dt-bindings/interrupt-controller/irq.h> > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > > > +#include <dt-bindings/power/mt8173-power.h> > > > > #include <dt-bindings/reset-controller/mt8173-resets.h> > > #include "mt8173-pinfunc.h" > > > > @@ -393,6 +394,37 @@ > > > > #size-cells = <0>; > > status = "disabled"; > > > > }; > > > > + > > + afe: mt8173-afe-pcm@11220000 { > > I believe this should be something generic, like: > > afe: audio-controller@11220000 > Yes, please find a name that better describes the component instead of just using the compatible string. Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html