Hi Daniel, > > +Required Properties: > > + > > +- compatible: Should be: > > + - "mediatek,mt8173-imgsys", "syscon" > > +- #clock-cells: Must be 1 > > + > > +The imgsys controller uses the common clk binding from > > +Documentation/devicetree/bindings/clock/clock-bindings.txt > > +The available clocks are defined in dt-bindings/clock/mt*-clk.h. > > + > > +Example: > > + > > +imgsys: imgsys@15000000 { > > Since these nodes will be supplying clocks to the rest of the system, > I think the "name" part of each of these should all be > "clock-controller", like topckgen and apmixedsys: > > imgsys: clock-controller@15000000 { These subsystems (and topckgen also) also contains other functions such as reset controller, which may be implemented in clk/mediatek/ in the future. It is suitable to use "clock-controller" as their name? Best regards, James -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html